Skip to content

Remove code with alpha1/2 to fix failing tests #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickersing merged 3 commits into from
Oct 15, 2025
Merged

Remove code with alpha1/2 to fix failing tests #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29025cb
Remove code with `alpha1/2`
bennibolm Oct 9, 2025
212b7a5
Use `get_node_vars`
bennibolm Oct 10, 2025
9a5fa0e
Restrict compat bound of Trixi.jl
bennibolm Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ Printf = "1"
Roots = "2.1.6"
Static = "1.1.1"
StaticArrays = "1.9"
Trixi = "0.13"
Trixi = "0.13.9"
julia = "1.10"
21 changes: 2 additions & 19 deletions src/solvers/subcell_limiters.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,13 @@ function (limiter::Trixi.SubcellLimiterIDP)(u::AbstractArray{<:Any, 4},
semi)
end

# Calculate alpha1 and alpha2
@unpack alpha1, alpha2 = limiter.cache.subcell_limiter_coefficients
Trixi.@threaded for element in eachelement(dg, semi.cache)
for j in eachnode(dg), i in 2:nnodes(dg)
alpha1[i, j, element] = max(alpha[i - 1, j, element], alpha[i, j, element])
end
for j in 2:nnodes(dg), i in eachnode(dg)
alpha2[i, j, element] = max(alpha[i, j - 1, element], alpha[i, j, element])
end

# Modification for wet/dry elements.
# (Re-)set dummy variable for alpha_dry
indicator_wet = 1

for j in eachnode(dg), i in 1:nnodes(dg)
h = waterheight(u[:, i, j, element], equations)
for j in eachnode(dg), i in eachnode(dg)
h = waterheight(get_node_vars(u, equations, dg, i, j, element), equations)

# Set indicator to FV if water height is below the threshold
if minimum(h) <= equations.threshold_partially_wet
Expand All @@ -58,15 +49,7 @@ function (limiter::Trixi.SubcellLimiterIDP)(u::AbstractArray{<:Any, 4},

if indicator_wet == 0 # element is dry
alpha[:, :, element] .= one(eltype(alpha))
alpha1[:, :, element] .= one(eltype(alpha1))
alpha2[:, :, element] .= one(eltype(alpha2))
end

# Use pure DG for interface fluxes
alpha1[1, :, element] .= zero(eltype(alpha1))
alpha1[nnodes(dg) + 1, :, element] .= zero(eltype(alpha1))
alpha2[:, 1, element] .= zero(eltype(alpha2))
alpha2[:, nnodes(dg) + 1, element] .= zero(eltype(alpha2))
end
return nothing
end
Expand Down
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ OrdinaryDiffEqSSPRK = "1.2"
Printf = "1"
Roots = "2.1.6"
Test = "1"
Trixi = "0.13"
Trixi = "0.13.9"
TrixiBottomTopography = "0.1"
TrixiTest = "0.1.4"
Loading