Conversation
Binary size comparison➡️ aarch64-apple-ios: 14.01 MB ➡️ aarch64-apple-ios-sim: 14.01 MB ➡️ aarch64-linux-android: 18.48 MB ➡️ armv7-linux-androideabi: 15.46 MB ➡️ wasm32-unknown-emscripten: 13.16 MB |
gupnik
changed the title
satoshiotomakan
suggested changes
Jun 2, 2025
satoshiotomakan
previously approved these changes
Jun 3, 2025
Contributor
satoshiotomakan
left a comment
satoshiotomakan
left a comment
There was a problem hiding this comment.
LGTM, let's wait for the codecov subscription
tracyharbutte13
added a commit
to tracyharbutte13/wallet-core
that referenced
this pull request
Jun 9, 2025
Adds Safety and Codecov CI (trustwallet#4408)
5 tasks
perpetua-engineering
pushed a commit
to perpetua-engineering/wallet-core
that referenced
this pull request
Feb 25, 2026
* Adds Rust Memory Leak Checker * FMT * Fix memory leaks * Adds codecov ci as well * Addresses review comments * Minor * Use `uname -s` * Adds dependencies install * Minor change * Moves coverage to rust ci * Minor fix * Minor * Minor * No need to install llm cov again * comment the codecov step for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the safety CI and fixes various memory leaks.
How to test
Run existing tests
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
If you're adding a new blockchain