Skip to content

Conversation

@Bobbins228
Copy link
Collaborator

@Bobbins228 Bobbins228 commented Oct 20, 2025

After the remote demo was updated the link in the rhoai example requires a change.

Also noticed a small typo in the demo itself.

Summary by Sourcery

Update demo reference in OpenShift README and fix typo in basic_demo notebook

Bug Fixes:

  • Fix typo in notebook comment ('usingf' to 'using')
  • Reset execution_count to null in basic_demo notebook

Documentation:

  • Update OpenShift README to point from remote_demo.ipynb to basic_demo.ipynb

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adjusts the basic_demo notebook by resetting its execution count metadata and correcting a comment typo, then updates the OpenShift demo README to point at basic_demo.ipynb instead of remote_demo.ipynb.

File-Level Changes

Change Details Files
Reset notebook execution metadata and correct typo
  • Set execution_count to null
  • Fixed 'usingf' → 'using' in comment
demos/basic_demo.ipynb
Update demo link in OpenShift README
  • Replaced remote_demo.ipynb link with basic_demo.ipynb
  • Rephrased descriptive text to match new link
demos/llama-stack-openshift/README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Bobbins228 Bobbins228 requested a review from dmaniloff October 20, 2025 11:23
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Collaborator

@dmaniloff dmaniloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @Bobbins228 !!

dmaniloff pushed a commit to dmaniloff/llama-stack-provider-ragas that referenced this pull request Oct 22, 2025
…ces/onboard-3.0-push-pipeline

add 3.0 push pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants