Skip to content

refactor(evalhub): remove control-plane jobs SA (tenant-only)#657

Merged
ruivieira merged 1 commit intotrustyai-explainability:dev/evalhub-multi-tenancyfrom
ruivieira:dev/evalhub-multi-tenancy-roles-sas
Mar 3, 2026
Merged

refactor(evalhub): remove control-plane jobs SA (tenant-only)#657
ruivieira merged 1 commit intotrustyai-explainability:dev/evalhub-multi-tenancyfrom
ruivieira:dev/evalhub-multi-tenancy-roles-sas

Conversation

@ruivieira
Copy link
Member

  • Remove control-plane jobs ServiceAccount creation from the reconcile loop
  • Remove associated RBAC methods and constants (createJobsAPIAccessRole, createJobsAPIAccessRoleBinding, generateJobsAPIAccessRoleName, mlflowJobsAccessClusterRoleName)
  • Remove the three call sites in createServiceAccount() that wired up jobs-specific Roles, RoleBindings, and MLFlow bindings
  • Remove corresponding unit and integration tests for the deleted code path

- Remove control-plane jobs ServiceAccount creation from the reconcile loop
- Remove associated RBAC methods and constants (createJobsAPIAccessRole, createJobsAPIAccessRoleBinding, generateJobsAPIAccessRoleName, mlflowJobsAccessClusterRoleName)
- Remove the three call sites in createServiceAccount() that wired up jobs-specific Roles, RoleBindings, and MLFlow bindings
- Remove corresponding unit and integration tests for the deleted code path
@ruivieira ruivieira self-assigned this Mar 3, 2026
@ruivieira ruivieira added the kind/enhancement New feature or request label Mar 3, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@mariusdanciu mariusdanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mariusdanciu

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit c756c98 into trustyai-explainability:dev/evalhub-multi-tenancy Mar 3, 2026
3 checks passed
@ruivieira ruivieira deleted the dev/evalhub-multi-tenancy-roles-sas branch March 3, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants