refactor(evalhub): remove control-plane jobs SA (tenant-only)#657
Conversation
ruivieira
commented
Mar 3, 2026
- Remove control-plane jobs ServiceAccount creation from the reconcile loop
- Remove associated RBAC methods and constants (createJobsAPIAccessRole, createJobsAPIAccessRoleBinding, generateJobsAPIAccessRoleName, mlflowJobsAccessClusterRoleName)
- Remove the three call sites in createServiceAccount() that wired up jobs-specific Roles, RoleBindings, and MLFlow bindings
- Remove corresponding unit and integration tests for the deleted code path
- Remove control-plane jobs ServiceAccount creation from the reconcile loop - Remove associated RBAC methods and constants (createJobsAPIAccessRole, createJobsAPIAccessRoleBinding, generateJobsAPIAccessRoleName, mlflowJobsAccessClusterRoleName) - Remove the three call sites in createServiceAccount() that wired up jobs-specific Roles, RoleBindings, and MLFlow bindings - Remove corresponding unit and integration tests for the deleted code path
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mariusdanciu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
c756c98
into
trustyai-explainability:dev/evalhub-multi-tenancy