feat:Require finetuned_model field in PATCH body for finetuned-models endpoint #200
Conversation
WalkthroughThe OpenAPI specification for the Cohere API's endpoint to update fine-tuned models was updated. The PATCH request body for Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API Server
Client->>API Server: PATCH /v1/finetuning/finetuned-models/{id} (name, settings, finetuned_model)
API Server-->>Client: Validates all required fields (name, settings, finetuned_model)
API Server-->>Client: Returns update result or error
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
coderabbitai
bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| - name | ||
| - settings | ||
| - finetuned_model | ||
| type: object |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Define schema for the newly required finetuned_model property.
You’ve added finetuned_model to the required list, but there’s no corresponding entry under properties. This will render the schema invalid and break client/server validation. Add a definition for finetuned_model with its type and description.
Proposed diff:
properties:
completed_at:
type: string
format: date-time
+ finetuned_model:
+ type: string
+ description: Identifier of the new fine-tuned model.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name | |
| - settings | |
| - finetuned_model | |
| type: object | |
| properties: | |
| completed_at: | |
| type: string | |
| format: date-time | |
| finetuned_model: | |
| type: string | |
| description: Identifier of the new fine-tuned model. |
🤖 Prompt for AI Agents
In src/libs/Cohere/openapi.yaml around lines 6340 to 6343, the schema lists
finetuned_model as a required property but does not define it under properties,
causing schema invalidity. Add a finetuned_model entry under properties with an
appropriate type (e.g., string) and a descriptive text explaining its purpose to
ensure proper validation.
Summary by CodeRabbit
finetuned_modelfield in addition tonameandsettingswhen submitting update requests. This ensures more comprehensive data is provided during model updates.