Skip to content

feat:Require finetuned_model field in PATCH body for finetuned-models endpoint #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HavenDV merged 1 commit into from
Jun 4, 2025
Merged

feat:Require finetuned_model field in PATCH body for finetuned-models endpoint #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/Cohere/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6339,6 +6339,7 @@ paths:
required:
- name
- settings
- finetuned_model
type: object
Comment on lines 6340 to 6343
Copy link

@coderabbitai coderabbitai bot Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Define schema for the newly required finetuned_model property.

You’ve added finetuned_model to the required list, but there’s no corresponding entry under properties. This will render the schema invalid and break client/server validation. Add a definition for finetuned_model with its type and description.

Proposed diff:

 properties:
   completed_at:
     type: string
     format: date-time
+  finetuned_model:
+    type: string
+    description: Identifier of the new fine-tuned model.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name
- settings
- finetuned_model
type: object
properties:
completed_at:
type: string
format: date-time
finetuned_model:
type: string
description: Identifier of the new fine-tuned model.
🤖 Prompt for AI Agents 
In src/libs/Cohere/openapi.yaml around lines 6340 to 6343, the schema lists
finetuned_model as a required property but does not define it under properties,
causing schema invalidity. Add a finetuned_model entry under properties with an
appropriate type (e.g., string) and a descriptive text explaining its purpose to
ensure proper validation.

properties:
completed_at:
Expand Down
Loading