[fix] Resolve ci error on missing BASE_DOMAIN #238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjlgao
force-pushed
the
jason/fix-base-domain-requirement
branch
3 times, most recently
from
6c9c1ee to
79ee991
Compare
jjlgao
force-pushed
the
jason/fix-base-domain-requirement
branch
from
79ee991 to
f8e6c99
Compare
ryanartecona
requested changes
Jun 6, 2025
| env: {} | ||
| env: | ||
| - name: BASE_DOMAIN | ||
| value: "CHANGE_ME" |
Contributor
There was a problem hiding this comment.
we can add this as a comment, but we shouldn't set it as a default. for any pre-existing deployment on an older version, if it didn't have a BASE_DOMAIN defined before and then the chart gets updated to include this default env value, the retool backend will start rejecting requests I think. that's worse than just leaving out a default BASE_DOMAIN even though it's required, and letting the pod error with an informative error message until the operator sets a value.
There was a problem hiding this comment.
@ryanartecona Can we add it but comment it out? Then highlight in the file itself that this env var is a requirement and users should uncomment it and update it to their base_domain.
Contributor
Author
|
Superseded by #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.