Skip to content

[fix] Resolve ci error on missing BASE_DOMAIN #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jjlgao wants to merge 2 commits into from
Closed

[fix] Resolve ci error on missing BASE_DOMAIN #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5218671
[fix] Resolve ci error on missing BASE_DOMAIN
jjlgao Jun 5, 2025
f8e6c99
add to backend template
jjlgao Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/retool/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 6.4.10
version: 6.4.11
maintainers:
- name: Retool Engineering
email: [email protected]
Expand Down
4 changes: 3 additions & 1 deletion charts/retool/ci/test-install-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ image:
commandline:
args: []

env: {}
env:
- name: BASE_DOMAIN
value: "CHANGE_ME"

# Optionally specify additional environment variables to be populated from Kubernetes secrets.
# Useful for passing in SCIM_AUTH_TOKEN or other secret environment variables from Kubernetes secrets.
Expand Down
4 changes: 3 additions & 1 deletion charts/retool/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ image:
commandline:
args: []

env: {}
env:
- name: BASE_DOMAIN
value: "CHANGE_ME"
Copy link
Contributor

@ryanartecona ryanartecona Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add this as a comment, but we shouldn't set it as a default. for any pre-existing deployment on an older version, if it didn't have a BASE_DOMAIN defined before and then the chart gets updated to include this default env value, the retool backend will start rejecting requests I think. that's worse than just leaving out a default BASE_DOMAIN even though it's required, and letting the pod error with an informative error message until the operator sets a value.

Copy link

@andre347 andre347 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanartecona Can we add it but comment it out? Then highlight in the file itself that this env var is a requirement and users should uncomment it and update it to their base_domain.


# Optionally specify additional environment variables to be populated from Kubernetes secrets.
# Useful for passing in SCIM_AUTH_TOKEN or other secret environment variables from Kubernetes secrets.
Expand Down
4 changes: 3 additions & 1 deletion values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ image:
commandline:
args: []

env: {}
env:
- name: BASE_DOMAIN
value: "CHANGE_ME"

# Optionally specify additional environment variables to be populated from Kubernetes secrets.
# Useful for passing in SCIM_AUTH_TOKEN or other secret environment variables from Kubernetes secrets.
Expand Down
Loading