Make CopyingTable into a separate function#504
Merged
jeromekelleher merged 1 commit intotskit-dev:mainfrom Jun 16, 2025
Merged
Conversation
Member
jeromekelleher
left a comment
There was a problem hiding this comment.
Looks good, and this is definitely a help. I don't see why it's a class though, when all you access from the return value is the html attribute? Might as well make it
def copying_table(ts, ..):
return html
87b55fb to
9070b15
Compare
Member
Author
|
I'm using the class to keep the various functions grouped together: I lose track of them when all stuck at the top level. I just reworked slightly to make it clearer. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to show a copying table without making a TreeInfo class, which is useful with the final tree sequence. It also cuts down on the number of lines of code, even with the extra test. You can call the new class as e.g.