Skip to content

Expose parentPostUri in ThreadPostEntity#1036

Merged
tunjid merged 3 commits intomainfrom
joel/expose-post-thread-parent-uri
Feb 27, 2026
Merged

Expose parentPostUri in ThreadPostEntity#1036
tunjid merged 3 commits intomainfrom
joel/expose-post-thread-parent-uri

Conversation

@joelmuraguri
Copy link
Collaborator

Adds parentPostUri to ThreadedPostEntity and updates the postThread DAO query to select it via a LEFT JOIN on the postThreads table.

@joelmuraguri joelmuraguri requested a review from tunjid February 23, 2026 18:14
@gemini-code-assist
Copy link

Summary of Changes

Hello @joelmuraguri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the data model for threaded posts by introducing a parentPostUri field to the ThreadedPostEntity. This change allows the application to explicitly track the parent of each post within a thread, improving the ability to navigate and display conversational structures. The corresponding database query has been updated to correctly populate this new field.

Highlights

  • ThreadedPostEntity Enhancement: The ThreadedPostEntity now includes a parentPostUri field, allowing for better representation of hierarchical relationships within post threads.
  • DAO Query Update: The postThread DAO query in PostDao.kt has been modified to select the new parentPostUri by performing a LEFT JOIN on the postThreads table and using a CASE statement to handle root posts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • data/database/src/commonMain/kotlin/com/tunjid/heron/data/database/daos/PostDao.kt
    • Modified the postThread SQL query to include parentPostUri by adding a LEFT JOIN to the postThreads table.
    • Implemented a CASE statement to set parentPostUri to NULL for root posts (generation 0) and retrieve it from the postThreads table otherwise.
  • data/database/src/commonMain/kotlin/com/tunjid/heron/data/database/entities/PostEntity.kt
    • Added parentPostUri: PostUri? as a new property to the ThreadedPostEntity data class.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully adds parentPostUri to ThreadedPostEntity and updates the postThread DAO query to include this new field. The changes are straightforward and align with the pull request description. The SQL query correctly uses a LEFT JOIN to retrieve the parentPostUri and handles the generation = 0 case by setting it to NULL.

val entity: PostEntity,
val generation: Long,
val rootPostUri: PostUri?,
val parentPostUri: PostUri?,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't update an entity without a migration, the app will crash.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, this is just an Entity in a query, it's not a persisted type.

@tunjid tunjid merged commit 408ddbd into main Feb 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose parent post information in the database query for post threads

2 participants