Expose parentPostUri in ThreadPostEntity#1036
Conversation
Summary of ChangesHello @joelmuraguri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the data model for threaded posts by introducing a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully adds parentPostUri to ThreadedPostEntity and updates the postThread DAO query to include this new field. The changes are straightforward and align with the pull request description. The SQL query correctly uses a LEFT JOIN to retrieve the parentPostUri and handles the generation = 0 case by setting it to NULL.
| val entity: PostEntity, | ||
| val generation: Long, | ||
| val rootPostUri: PostUri?, | ||
| val parentPostUri: PostUri?, |
There was a problem hiding this comment.
You can't update an entity without a migration, the app will crash.
There was a problem hiding this comment.
Oh I see, this is just an Entity in a query, it's not a persisted type.
Adds
parentPostUritoThreadedPostEntityand updates thepostThreadDAO query to select it via a LEFT JOIN on the postThreads table.