Skip to content

Expose parentPostUri in ThreadPostEntity #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tunjid merged 3 commits into from
Feb 27, 2026
Merged

Expose parentPostUri in ThreadPostEntity #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbc2000
add parentPostUri to ThreadedPostEntity
joelmuraguri Feb 23, 2026
f0c2f99
select parentPostUri in postThread DAO query
joelmuraguri Feb 23, 2026
d78e18c
simplify parentPostUri selection in postThread query
joelmuraguri Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion data/database/src/commonMain/kotlin/com/tunjid/heron/data/database/daos/PostDao.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,11 +396,14 @@ interface PostDao {
ft.rootPostUri AS rootPostUri,
ft.generation AS generation,
ft.ancestorCreated AS ancestorCreated,
ft.postCreated AS postCreated
ft.postCreated AS postCreated,
pt.parentPostUri AS parentPostUri
FROM
posts p
JOIN
FullThread ft ON p.uri = ft.uri
LEFT JOIN
postThreads pt ON pt.postUri = p.uri
ORDER BY
ft.ancestorCreated, ft.generation, ft.postCreated; -- sort by the first reply to the op, then the generation, then the post itself
""",
Expand Down
1 change: 1 addition & 0 deletions data/database/src/commonMain/kotlin/com/tunjid/heron/data/database/entities/PostEntity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ data class ThreadedPostEntity(
val entity: PostEntity,
val generation: Long,
val rootPostUri: PostUri?,
val parentPostUri: PostUri?,
Copy link
Owner

@tunjid tunjid Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't update an entity without a migration, the app will crash.

Copy link
Owner

@tunjid tunjid Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, this is just an Entity in a query, it's not a persisted type.

)

fun PopulatedPostEntity.asExternalModel(
Expand Down