Show ISO week numbers for all week start preferences#9812
Open
TheHappyFella wants to merge 1 commit intotutao:masterfrom
Open
Show ISO week numbers for all week start preferences#9812TheHappyFella wants to merge 1 commit intotutao:masterfrom
TheHappyFella wants to merge 1 commit intotutao:masterfrom
Conversation
Previously, ISO week numbers were only displayed for users with Monday as their week start day. This excluded users who prefer Sunday or Saturday as their week start. ISO 8601 week numbers are always Monday-based regardless of display preference, so it's useful to show them for all users. This allows users with different week start preferences to see standardized week numbers for scheduling and coordination. - Remove WeekStart.MONDAY restriction in CalendarMonthView - Week numbers now display for Sunday, Monday, and Saturday start users - ISO 8601 standard is maintained (weeks always start Monday internally)
Author
|
@charlag can you review this one too please? |
Contributor
|
@TheHappyFella hey. I don't think it's a good idea to be honest, we should use the week numbers as they are expected or not at all but I would have to check in with our Product Owner once he's available. |
Author
|
@charlag Let me know what the PO thinks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9811
Summary
Removes the Monday-only restriction for displaying ISO week numbers in calendar month view. Users with Sunday or Saturday week starts can
now see week numbers, while maintaining ISO 8601 standard internally (weeks always Monday-based).
Changes
WeekStart.MONDAYcondition fromCalendarMonthView.ts:332-343Testing
Motivation
ISO 8601 week numbering is internationally recognized regardless of which day users prefer their week to start on. The previous restriction
unnecessarily limited this useful feature to Monday-start users only.
Technical Details
DateTime.weekNumber(ISO 8601 compliant)Platform Compatibility
Screenshots/Evidence
Week numbers now visible for Sunday week start users
Security Considerations
None - UI display change only, no data or privacy implications