Skip to content

Show ISO week numbers for all week start preferences #9812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheHappyFella wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Show ISO week numbers for all week start preferences #9812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/calendar-app/calendar/view/CalendarMonthView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,10 +329,8 @@ export class CalendarMonthView implements Component<CalendarMonthAttrs>, ClassCo
height: px(SELECTED_DATE_INDICATOR_THICKNESS),
},
}),
this.renderDayHeader(day, attrs.onDateSelected), // According to ISO 8601, weeks always start on Monday. Week numbering systems for
// weeks that do not start on Monday are not strictly defined, so we only display
// a week number if the user's client is configured to start weeks on Monday
weekDayNumber === 0 && attrs.startOfTheWeek === WeekStart.MONDAY
this.renderDayHeader(day, attrs.onDateSelected),
weekDayNumber === 0
? m(
".calendar-month-week-number.abs.z3",
{
Expand Down