Enable default buildifier lint warnings and clean up #2323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add docstring to aspect.
Make reexported_modules attr require a `HaskellLibraryInfo` provider and simplify handling.
avdv
force-pushed
the
cb/fix-lint-warnings
branch
2 times, most recently
from
515b0da to
d7ed85b
Compare
The objdump output contained these entries: ``` 0x70000000 0x0000000000010230 0x70000001 0x00000000000001f0 0x70000003 0x0000000000000010 ``` which could not be processed and failed. Raise an exception with more details if that happens again.
All callers of _run_ghc pass a depset as `inputs`.
The attribute was a no-op since 0.17 already.
This likely needs to be fixed for full bzlmod support.
avdv
force-pushed
the
cb/fix-lint-warnings
branch
from
d7ed85b to
f7f1d0e
Compare
avdv
commented
Aug 11, 2025
| "-native-proto", | ||
| "-native-proto-common", | ||
| "-native-proto-info", | ||
| "-module-docstring", |
There was a problem hiding this comment.
We will get to fixing them eventually, but I disabled them for now. I'll add an issue to work on the TODOs after this is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a few problems I discovered:
f3e7187(#2323)4f800a3(#2323)