Skip to content

Enable default buildifier lint warnings and clean up #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Enable default buildifier lint warnings and clean up #2323

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
82b94a8
Enable default lint warnings with some disabled
avdv Aug 1, 2025
4226e72
Suppress print linter warnings
avdv Aug 1, 2025
2c860de
Fix no-effect lint warning
avdv Aug 1, 2025
6c9a8fc
Suppress no-effect warning
avdv Aug 1, 2025
5fb6cc7
Fix no-effect warnings
avdv Aug 1, 2025
0b999bb
Fix return-value warnings
avdv Aug 1, 2025
6a89172
Fix uninitialized warning
avdv Aug 1, 2025
07ee9a7
Fix uninitialized warning
avdv Aug 1, 2025
27ca344
Fix uninitialized warning
avdv Aug 1, 2025
f3e7187
Accept hexadecimal field keys in dynamic section
avdv Aug 2, 2025
06284a6
Explicitly depend on rules_shell
avdv Aug 4, 2025
9d37bf4
Auto-fix warnings
avdv Aug 4, 2025
841a5e4
rules_haskell_nix: Always enable bzlmod
avdv Aug 4, 2025
4f800a3
rules_haskell_nix: Override path to rules_haskell
avdv Aug 4, 2025
c002648
rules_haskell_nix: Update dependencies
avdv Aug 4, 2025
b68c7b4
Fix positional-args warning
avdv Aug 5, 2025
2b95128
Fix name-conventions warnings
avdv Aug 5, 2025
bfe8a58
Fix confusing-name warnings
avdv Aug 5, 2025
6cc5ce1
Fix depset-union warning
avdv Aug 5, 2025
0032dbc
Fix overly-nested-depset warnings
avdv Aug 5, 2025
3fe8bbf
Remove `hie_bios_path_prefix` attr from `haskell_repl`
avdv Aug 5, 2025
72b9d0a
Fix unnamed-macro warnings
avdv Aug 8, 2025
0dd61cd
Disable provider-params warnings
avdv Aug 8, 2025
29fa920
Disable bzl-visibility warnings
avdv Aug 8, 2025
3f40c24
Load `sh_test` and `sh_binary` rules from rules_shell
avdv Aug 8, 2025
f7f1d0e
Add dependency on rules_shell to workspace
avdv Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions buildifier/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,20 @@ buildifier_exclude_patterns = [
]

_lint_warnings = [
"load",
"unused-variable",
"-function-docstring", # TODO
"-function-docstring-args", # TODO
"-function-docstring-header", # TODO
"-function-docstring-return", # TODO
"-native-cc-common",
"-native-cc-info",
"-native-cc-library",
"-native-cc-shared-library-info",
"-native-java-common",
"-native-java-info",
"-native-proto",
"-native-proto-common",
"-native-proto-info",
"-module-docstring",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will get to fixing them eventually, but I disabled them for now. I'll add an issue to work on the TODOs after this is merged.

]

# Run this to fix the errors in BUILD files.
Expand Down