Skip to content

Correctly update the video orientation after the permission prompt appeared #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correctly update the video orientation after the permission prompt appeared #166

wants to merge 1 commit into from

Conversation

ralfebert
Copy link
Contributor

  • When the permission prompt appears, updateOrientation was called before the AV connection was established and the orientation was not updated afterwards when the connection is available
  • Update previewLayer.connection instead of captureSession?.connections.last
  • Remove implicit forced unwrap for previewLayer property

@ralfebert
Correctly update the video orientation after the permission prompt ap…
52d1395 
…peared

- When the permission prompt appears, updateOrientation was called before the AV connection was established and not updated afterwards
- Update previewLayer.connection instead of captureSession?.connections.last
- Remove implicit forced unwrap for previewLayer property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ralfebert