Skip to content

Correctly update the video orientation after the permission prompt appeared #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correctly update the video orientation after the permission prompt appeared #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/CodeScanner/ScannerViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ extension CodeScannerView {
#else

var captureSession: AVCaptureSession?
var previewLayer: AVCaptureVideoPreviewLayer!
var previewLayer: AVCaptureVideoPreviewLayer?

private lazy var viewFinder: UIImageView? = {
guard let image = UIImage(named: "viewfinder", in: .module, with: nil) else {
Expand Down Expand Up @@ -148,7 +148,7 @@ extension CodeScannerView {

@objc func updateOrientation() {
guard let orientation = view.window?.windowScene?.interfaceOrientation else { return }
guard let connection = captureSession?.connections.last, connection.isVideoOrientationSupported else { return }
guard let previewLayer, let connection = previewLayer.connection, connection.isVideoOrientationSupported else { return }
switch orientation {
case .portrait:
connection.videoOrientation = .portrait
Expand Down Expand Up @@ -183,8 +183,10 @@ extension CodeScannerView {
previewLayer = AVCaptureVideoPreviewLayer(session: captureSession)
}

let previewLayer = self.previewLayer!
previewLayer.frame = view.layer.bounds
previewLayer.videoGravity = .resizeAspectFill
updateOrientation()
view.layer.addSublayer(previewLayer)
addViewFinder()

Expand Down