Switch to uv_build build system & cleanup
#2848
Conversation
* Switched `hatchling` -> `uv_build` * Removed useless `twine check` from `build-and-check` CI job
|
Similar to Such as Diffs: https://gist.github.com/intgr/dd8c503bc93148eef1f1e8632fff850e |
| @@ -1,7 +1,3 @@ | |||
| [build-system] | |||
| requires = ["hatchling"] | |||
| build-backend = "hatchling.build" | |||
There was a problem hiding this comment.
I never liked that this was at the top of the file; moved to below package metadata.
There was a problem hiding this comment.
We can also lean on https://github.com/tox-dev/pyproject-fmt/ for a consistent sort
| [tool.hatch.build] | ||
| packages = ["django_stubs_ext"] | ||
| [build-system] | ||
| requires = ["uv_build>=0.8.22,<0.9.0"] |
There was a problem hiding this comment.
Do we need to be this specific? Will "uv_build>=0.8" work?
There was a problem hiding this comment.
This is recommended by official docs https://docs.astral.sh/uv/concepts/build-backend/#using-the-uv-build-backend
I guess patchlevel versions may contain fixes, I see no reason to allow downgrading to more buggy versions given that we haven't tested with them.
| uv build ext/ | ||
| - name: Check package metadata | ||
| run: | | ||
| uvx twine check --strict dist/* |
There was a problem hiding this comment.
Does uv has an alternative with a dry-run?
There was a problem hiding this comment.
See #2846 (comment) - twine check is only making sure that rST is valid in the long description, but we're using markdown.
| [tool.hatch.build] | ||
| packages = ["django_stubs_ext"] | ||
| [build-system] | ||
| requires = ["uv_build>=0.8.22,<0.9.0"] |
There was a problem hiding this comment.
Why isn't @dependabot updating this? 🤔
It updated in djangorestframework-stubs:
5 participants
Solving follow-ups from #2846 comments.
hatchling->uv_buildtwine checkfrombuild-and-checkCI job