chore: use SessionFunctionKwargs directly instead of unpacking #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy doesn't infer the typed dict type correctly, resulting in type errors, this isn't ideal.
- Check for existence of keys and assert their types, instead of checking for their values
tharropoulos
changed the title
kishorenc
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This pull request includes changes to the
src/typesense/api_call.pyfile to address types errors for keyword arguments in several methods. The changes replace the use oftyping.Unpackwithtyping.Anyfor the**kwargsparameter in multiple methods.Mypy can't decipher that the imported type is indeed extending a TypedDict, resulting in mypy errors on CI.
src/typesense/api_call.py: Modified the**kwargsparameter in the_execute_requestmethod to usetyping.Anyinstead oftyping.Unpack[SessionFunctionKwargs[TParams, TBody]]for three different method signatures. [1] [2] [3]src/typesense/api_call.py: Modified the**kwargsparameter in the_make_request_and_process_responsemethod to usetyping.Anyinstead oftyping.Unpack[SessionFunctionKwargs[TParams, TBody]].PR Checklist