Skip to content

chore: use SessionFunctionKwargs directly instead of unpacking #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tharropoulos wants to merge 3 commits into from
Closed

chore: use SessionFunctionKwargs directly instead of unpacking #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a41471
chore: cast kwargs as any in api call module
tharropoulos Feb 16, 2025
f354e6a
test: change integration test for debug to avoid future failures
tharropoulos Feb 16, 2025
e1f88c2
fix(api_call): use SessionFunctionKwargs directly instead of unpacking
tharropoulos Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/typesense/api_call.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def _execute_request(
as_json: typing.Literal[True],
last_exception: typing.Union[None, Exception] = None,
num_retries: int = 0,
**kwargs: typing.Unpack[SessionFunctionKwargs[TParams, TBody]],
**kwargs: SessionFunctionKwargs[TParams, TBody],
) -> TEntityDict:
"""
Execute a request to the Typesense API with retry logic.
Expand Down Expand Up @@ -373,7 +373,7 @@ def _execute_request(
as_json: typing.Literal[False],
last_exception: typing.Union[None, Exception] = None,
num_retries: int = 0,
**kwargs: typing.Unpack[SessionFunctionKwargs[TParams, TBody]],
**kwargs: SessionFunctionKwargs[TParams, TBody],
) -> str:
"""
Execute a request to the Typesense API with retry logic.
Expand Down Expand Up @@ -411,7 +411,7 @@ def _execute_request(
as_json: typing.Union[typing.Literal[True], typing.Literal[False]] = True,
last_exception: typing.Union[None, Exception] = None,
num_retries: int = 0,
**kwargs: typing.Unpack[SessionFunctionKwargs[TParams, TBody]],
**kwargs: SessionFunctionKwargs[TParams, TBody],
) -> typing.Union[TEntityDict, str]:
"""
Execute a request to the Typesense API with retry logic.
Expand Down Expand Up @@ -473,7 +473,7 @@ def _make_request_and_process_response(
url: str,
entity_type: typing.Type[TEntityDict],
as_json: bool,
**kwargs: typing.Any,
**kwargs: SessionFunctionKwargs[TParams, TBody],
) -> typing.Union[TEntityDict, str]:
"""Make the API request and process the response."""
request_response = self.request_handler.make_request(
Expand All @@ -493,7 +493,7 @@ def _make_request_and_process_response(
def _prepare_request_params(
self,
endpoint: str,
**kwargs: typing.Unpack[SessionFunctionKwargs[TParams, TBody]],
**kwargs: SessionFunctionKwargs[TParams, TBody],
) -> typing.Tuple[Node, str, SessionFunctionKwargs[TParams, TBody]]:
node = self.node_manager.get_node()
url = node.url() + endpoint
Expand Down
10 changes: 6 additions & 4 deletions tests/debug_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ def test_retrieve(fake_debug: Debug) -> None:


def test_actual_retrieve(actual_debug: Debug) -> None:
"""Test that the Debug object can retrieve a debug on Typesense server."""
json_response: DebugResponseSchema = {"state": 1, "version": "27.0"}

"""Test that the Debug object can retrieve a debug on Typesense server and verify response structure."""
response = actual_debug.retrieve()

assert response == json_response
assert "state" in response
assert "version" in response

assert isinstance(response["state"], int)
assert isinstance(response["version"], str)