Skip to content

Reduce memory footprint.#1517

Open
jm-franc wants to merge 1 commit intouber-go:masterfrom
jm-franc:memory-optimize
Open

Reduce memory footprint.#1517
jm-franc wants to merge 1 commit intouber-go:masterfrom
jm-franc:memory-optimize

Conversation

@jm-franc
Copy link
Copy Markdown

@jm-franc jm-franc commented Oct 28, 2025

Divides the memory footprint of a sampler instance by 7 (from ~0.5MB to 65KB), at the expense of a small increase in over-sampling chances.

#1516

Divides the memory footprint of a sampler instance by 7 (from
~0.5MB to 65KB), at the expense of a small increase in
over-sampling chances.
@jm-franc
Copy link
Copy Markdown
Author

jm-franc commented Nov 4, 2025

/assign sywhang

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.70%. Comparing base (07077a6) to head (59499db).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
+ Coverage   98.59%   98.70%   +0.11%     
==========================================
  Files          53       53              
  Lines        3565     3023     -542     
==========================================
- Hits         3515     2984     -531     
+ Misses         42       31      -11     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sywhang
Copy link
Copy Markdown
Contributor

sywhang commented Mar 12, 2026

Sorry, not sure why this didn't actually assign me to this PR so I only came across this PR now.

Do you have any empirical data you can share on this PR?

@prashantv
Copy link
Copy Markdown
Collaborator

Sharing my comment here too

I think this is a good idea, though I'd prefer if it was opt-in, maybe as a setting on the SamplingConfig.

My worry is that a version upgrade changing the sampling behaviour significantly could be surprising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants