Skip to content

Reduce memory footprint. #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jm-franc wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −8
Open

Reduce memory footprint. #1517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions zapcore/sampler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,34 +26,39 @@ import (
)

const (
_numLevels = _maxLevel - _minLevel + 1
_countersPerLevel = 4096
_counterBuckets = 4096
)

type counter struct {
resetAt atomic.Int64
counter atomic.Uint64
}

type counters [_numLevels][_countersPerLevel]counter
type counters [_counterBuckets]counter

func newCounters() *counters {
return &counters{}
}

func (cs *counters) get(lvl Level, key string) *counter {
i := lvl - _minLevel
j := fnv32a(key) % _countersPerLevel
return &cs[i][j]
j := fnv32a(lvl, key) % _counterBuckets
return &cs[j]
}

// fnv32a, adapted from "hash/fnv", but without a []byte(string) alloc
func fnv32a(s string) uint32 {
// fnv32a returns a hash of its arguments. It is adapted from "hash/fnv", but
// without a []byte(string) alloc.
func fnv32a(lvl Level, s string) uint32 {
const (
offset32 = 2166136261
prime32 = 16777619
)
hash := uint32(offset32)

// Hash lvl
hash ^= uint32(lvl)
hash *= prime32

// Hash s
for i := 0; i < len(s); i++ {
hash ^= uint32(s[i])
hash *= prime32
Expand Down
Loading