Merged
Conversation
Contributor
Author
|
@0x4007 FYI @nevillehuang Could you review the fixes? |
This was referenced Sep 15, 2025
Merged
Closed
Contributor
Author
There was a problem hiding this comment.
Pull Request Overview
This PR implements audit fixes for the staking system to address security and functionality issues identified in an audit. The changes focus on improving input validation, maintaining consistency in reward calculations, and adding proper safety checks.
- Adds validation to prevent staking in disabled pools (allocation points = 0)
- Ensures pool state consistency by calling
massUpdateStakingPools()before parameter changes - Strengthens validation for staking start block updates
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| LibStaking.sol | Adds pool validation, state consistency updates, and enhanced start block validation |
| StakingFacet.t.sol | Updates test cases with corrected reward calculations and adds validation tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
0x4007
approved these changes
Sep 16, 2025
whilefoo
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies these proposed fixes for issues found in #1002.