Skip to content

Conversation

@inffy
Copy link
Member

@inffy inffy commented Jan 7, 2026

Copilot AI review requested due to automatic review settings January 7, 2026 14:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the ISO build workflow to generate a flatpak list dynamically from the common repository's Brewfile format instead of using a pre-existing .list file. The change replaces a GitHub Actions checkout step with an inline git clone and processing pipeline.

  • Removes the dedicated checkout step for the common repository
  • Adds a new step that clones the common repository and transforms Brewfile entries into a titanoboa-compatible flatpak list
  • Changes the flatpaks-list input to use a dynamically generated temporary file instead of a static file path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@inffy inffy changed the title feat: get ISO flatpaks from common chore(flatpak,iso): get flatpaks from common Jan 8, 2026
@inffy
Copy link
Member Author

inffy commented Jan 8, 2026

Seems to work locally.

Not sure about the ISO stuff but it should work. Think we can't build ISOs at the moment because of the bootc bug(?)

@inffy inffy marked this pull request as ready for review January 8, 2026 10:46
@inffy inffy marked this pull request as draft January 8, 2026 17:54
@inffy inffy marked this pull request as ready for review January 11, 2026 08:23
@inffy inffy enabled auto-merge January 12, 2026 15:04
@renner0e renner0e disabled auto-merge January 12, 2026 15:15
@renner0e renner0e merged commit 1970b35 into ublue-os:main Jan 12, 2026
10 checks passed
@inffy inffy deleted the flatpaks-from-common branch January 25, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants