feat: move flatpak lists to brewflles #97
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the flatpak installation process to use Homebrew's brew bundle with Brewfiles, which is a positive change. However, the implementation introduces some significant issues in the justfile recipes. The toggle-devmode recipe contains flawed logic for detecting and disabling developer mode, which could fail for certain image names. More critically, the install-system-flatpaks recipe is broken and will not install development flatpaks when switching to developer mode. I have provided two review comments with high and critical severity to address these bugs, including code suggestions to resolve them.
inffy
requested review from
NiHaiden,
hanthor,
ledif and
renner0e
as code owners
|
Tested locally and the brewfiles are in the correct place and the install-system-flatpak commands seem to work. Would prefer another eyes and testing round for this though. |
|
What about ISOs? |
ISOs are still at ublue-os/aurora and this should make them ublue-os/aurora#1604 But we don't have testing ISO repo at the moment and we can't build new ISOs because of the bootc bug afaik |
inffy
force-pushed
the
flatpak-brewfiles
branch
from
efb4c62 to
7ecd187
Compare
not needed anymore
fix the brewfiles fix typo small typo in comments
inffy
force-pushed
the
flatpak-brewfiles
branch
from
7ecd187 to
6f96017
Compare
|
Removed the toggle-devmode parts as need to check tulips new stuff. |
2 participants
Closes #84
From projectbluefin/common@ac474a8
Also needed for ISOs ublue-os/aurora#1604