Close alignment panel with Escape key#814
Open
deferredreward wants to merge 1 commit intounfoldingWord:developfrom
Open
Close alignment panel with Escape key#814deferredreward wants to merge 1 commit intounfoldingWord:developfrom
deferredreward wants to merge 1 commit intounfoldingWord:developfrom
Conversation
Pressing Escape now triggers cancelAlignment, same as clicking the Cancel button. Also wires MUI Dialog's onClose to cancelAlignment so both keyboard and backdrop-click paths work. https://claude.ai/code/session_01GFFH8RDgpXR1cnfXxukc3A
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 14f0189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #813
What this addresses
Escapewhile the alignment panel is open now closes it, equivalent to clicking CancelChanges
keydownevent listener inWordAlignerDialogthat callscancelAlignment()on Escape while the dialog is shownonClose(previously a no-op) to also callcancelAlignment(), consistent with the Escape key behaviorTest Instructions
Escape— panel should close without saving changes