Skip to content

Close alignment panel with Escape key #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deferredreward wants to merge 1 commit into
base: develop
Choose a base branch
from
+13 −1
Open

Close alignment panel with Escape key #814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/components/WordAlignerDialog.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,17 @@ function WordAlignerDialog({
}
} = alignmentSuggestionsManage; // type is TUseAlignmentSuggestionsReturn

useEffect(() => { // close dialog on Escape key
if (!showDialog) return;
const handleKeyDown = (e) => {
if (e.key === 'Escape') {
alignmentActions_?.cancelAlignment();
}
};
window.addEventListener('keydown', handleKeyDown);
return () => window.removeEventListener('keydown', handleKeyDown);
}, [showDialog, alignmentActions_]);

useEffect(() => {
if (shouldShowDialog_ !== showDialog) {
console.log(`WordAlignerDialog: alignment data changed shouldShowDialog_ ${shouldShowDialog_}`)
Expand Down Expand Up @@ -343,7 +354,7 @@ function WordAlignerDialog({
<Dialog
fullWidth={true}
maxWidth={'lg'}
onClose={() => {}}
onClose={() => alignmentActions_?.cancelAlignment()}
open={!!showDialog}
PaperComponent={PaperComponent}
bounds={bounds}
Expand Down Expand Up @@ -378,6 +389,7 @@ function WordAlignerDialog({
)
},
[
alignmentActions_,
contextId,
errorMessage,
showDialog,
Expand Down
Loading