CLDR-18294 Add unit test for inheriting null, and fix two items in xml #4366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Combine the test with TestCheckCLDR to avoid another cycle through factory.getAvailable -New method checkNullWithInheritanceMark -Skip and log known issue for paths not in LANGUAGE/SCRIPT/TERRITORY/VARIANT
btangmu
commented
Feb 12, 2025
| LanguageTagParser ltp = new LanguageTagParser(); | ||
| Set<String> locales = new HashSet<>(); | ||
| for (String locale : getInclusion() <= 5 ? eightPointLocales : factory.getAvailable()) { | ||
| checkNullWithInheritanceMark(locale); |
Member
Author
There was a problem hiding this comment.
Actually I've just realized, this doesn't really avoid adding a cycle through the locales, since the original test waits until after this loop to cycle with checkLocale
Given the hurry to get this ready, I suggest merging this anyway and following up to address the performance
srl295
approved these changes
Feb 12, 2025
| assertNotNull(locale + " " + path, resolved.getStringValue(path)); | ||
| break; | ||
| default: | ||
| if (!logKnownIssue("CLDR-18294", "Null with inheritance mark")) { |
Member
There was a problem hiding this comment.
needs to be a new ticket (48) for after 18294 is already fixed.
Member
Author
There was a problem hiding this comment.
I'll follow up with that; merging now to fix the data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Combine the test with TestCheckCLDR to avoid another cycle through factory.getAvailable
-New method checkNullWithInheritanceMark
-Skip and log known issue for paths not in LANGUAGE/SCRIPT/TERRITORY/VARIANT
CLDR-18294
ALLOW_MANY_COMMITS=true