Skip to content

Conversation

@grhoten
Copy link
Member

@grhoten grhoten commented Oct 26, 2025

CLDR-16292

This is a revised submission of #2769. It changes RBNF to use the new plural format values.

  • This PR completes the ticket.

@grhoten
Copy link
Member Author

grhoten commented Oct 29, 2025

@srl295 @AEApple for review as per the CLDR TC meeting. I can't request a reviewer here.

@srl295 srl295 requested review from AEApple and srl295 October 29, 2025 16:15
@AEApple
Copy link
Contributor

AEApple commented Oct 30, 2025

Can you fix the minimal pairs for the ordinals?

<ordinalMinimalPairs ordinal="other">Toma la {0}.ª a la derecha.</ordinalMinimalPairs>

I don't think they use RBNF logic right now and I think they have to be updated manually.

@grhoten
Copy link
Member Author

grhoten commented Oct 30, 2025

Err, that's grammatically correct. The singular masculine, singular feminine, plural masculine, and plural feminine all have a single grammatical state. Only the adjective form of the ordinal uses the er suffix, which has 2 grammatical states.

I mean an alternate exemplar translation could be this translation. I'm not a native Spanish speaker. So I'm not 100% sure about the grammatical correctness. Is this the one that you want?

<ordinalMinimalPairs ordinal="one">El {0}.ᵉʳ equipo clasificado ganó.</ordinalMinimalPairs>
<ordinalMinimalPairs ordinal="other">El {0}.º equipo clasificado ganó.</ordinalMinimalPairs>

@jbezos
Copy link

jbezos commented Nov 1, 2025

I’m a native Spanish speaker and “El {0}.ᵉʳ equipo clasificado ganó” is correct. However, “El {0}.º equipo clasificado ganó” is not correct. But if the ordinal is placed after the noun, then it is “El equipo {0}.º“. They are masculine. Feminine is “{0}.ª”.

AEApple
AEApple previously approved these changes Nov 4, 2025
Copy link
Contributor

@AEApple AEApple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this one, but let's update the plurals minimal pairs before resolving the ticket since this change updates the plurals.

I think one of the open questions for me is what to do about the grammatical gender since we do have support for certain unit types even if it's not available everywhere.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/es_419.xml is now changed in the branch
  • common/main/es.xml is now changed in the branch
  • common/supplemental/ordinals.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@grhoten grhoten changed the title CLDR-16292 Plural rules in Spanish should return different ordinal types for number 1 and 3 CLDR-16292 Ordinal plural rules in Spanish should return different ordinal types for number 1 and 3 Nov 4, 2025
@grhoten grhoten changed the title CLDR-16292 Ordinal plural rules in Spanish should return different ordinal types for number 1 and 3 CLDR-16292 Plural rules in Spanish should return different ordinal types for number 1 and 3 Nov 4, 2025
@grhoten
Copy link
Member Author

grhoten commented Nov 4, 2025

@AEApple I've updated the minimal pairs for both Spanish variants. The digit ordinals have also been fixed to use the correct localized form of the digit ordinals between the base es and es_419. The es_419 locale must override this usage due to differing punctuation usage.

The existing gender usage of genderMinimalPairs in Spanish seems correct. There are traditionally only 2 grammatical genders. If you want to go into a deeper philosophical debate about that, I recommend separating such discussions out to a separate ticket.

@AEApple
Copy link
Contributor

AEApple commented Nov 4, 2025

@AEApple I've updated the minimal pairs for both Spanish variants. The digit ordinals have also been fixed to use the correct localized form of the digit ordinals between the base es and es_419. The es_419 locale must override this usage due to differing punctuation usage.

The existing gender usage of genderMinimalPairs in Spanish seems correct. There are traditionally only 2 grammatical genders. If you want to go into a deeper philosophical debate about that, I recommend separating such discussions out to a separate ticket.

no, I meant right now I don't think the plural charts had grammatical gender at all in any language, but I could have missed something.

p.s. You should be able to merge changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants