-
Notifications
You must be signed in to change notification settings - Fork 412
CLDR-16292 Plural rules in Spanish should return different ordinal types for number 1 and 3 #5163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you fix the minimal pairs for the ordinals? Line 7734 in e1ac2ae
I don't think they use RBNF logic right now and I think they have to be updated manually. |
|
Err, that's grammatically correct. The singular masculine, singular feminine, plural masculine, and plural feminine all have a single grammatical state. Only the adjective form of the ordinal uses the er suffix, which has 2 grammatical states. I mean an alternate exemplar translation could be this translation. I'm not a native Spanish speaker. So I'm not 100% sure about the grammatical correctness. Is this the one that you want? |
|
I’m a native Spanish speaker and “El {0}.ᵉʳ equipo clasificado ganó” is correct. However, “El {0}.º equipo clasificado ganó” is not correct. But if the ordinal is placed after the noun, then it is “El equipo {0}.º“. They are masculine. Feminine is “{0}.ª”. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve this one, but let's update the plurals minimal pairs before resolving the ticket since this change updates the plurals.
I think one of the open questions for me is what to do about the grammatical gender since we do have support for certain unit types even if it's not available everywhere.
…pes for number 1 and 3
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
@AEApple I've updated the minimal pairs for both Spanish variants. The digit ordinals have also been fixed to use the correct localized form of the digit ordinals between the base es and es_419. The es_419 locale must override this usage due to differing punctuation usage. The existing gender usage of genderMinimalPairs in Spanish seems correct. There are traditionally only 2 grammatical genders. If you want to go into a deeper philosophical debate about that, I recommend separating such discussions out to a separate ticket. |
no, I meant right now I don't think the plural charts had grammatical gender at all in any language, but I could have missed something. p.s. You should be able to merge changes now. |
CLDR-16292
This is a revised submission of #2769. It changes RBNF to use the new plural format values.