-
Notifications
You must be signed in to change notification settings - Fork 225
Streamline more error cases around month code parsing #7105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really want us to switch to a new month code everywhere. When I mentioned ValidMonthCode I was narrowly mentioning it as a potential unstable API for ecma_reference_year
.
In the medium term we can consider migrating.
8c322ce
to
fc91514
Compare
fc91514
to
d7dce4e
Compare
I made the type fully internal. For now I'm passing tuples into the Rules traits. We should revisit whether to export ValidMonthCode when we graduate the Rules traits in 2.2. |
I like this |
I'll wait on @robertbastian since he usually has feedback on errors. autosubmit = true |
Note: this PR changes |
#7010
This adds ValidMonthCode as an internal type.
Suggested in #7100