Made Location::try_new public#7775
Merged
Manishearth merged 5 commits intounicode-org:mainfrom Mar 13, 2026
Merged
Conversation
In order to get observational islamic date for locations other than `MECCA` and `CAIRO`
Manishearth
approved these changes
Mar 12, 2026
Member
Manishearth
left a comment
There was a problem hiding this comment.
I think this is fine, but we should be careful about new public APIs
If htis is public, do we think it's sufficiently well-documented?
Contributor
Author
|
I've updated the docs to include utc_offset bound |
sffc
approved these changes
Mar 13, 2026
Member
sffc
left a comment
There was a problem hiding this comment.
I'm in favor of making calendrical_calculations more useful. I've also hit situations before where constructors that "should be" public were just not public.
…s these consts are not publicly accessible
Manishearth
approved these changes
Mar 13, 2026
Member
|
Please fix the doc CI issue (ignore the semver one, I don't know why that's failing) |
sffc
approved these changes
Mar 13, 2026
Manishearth
approved these changes
Mar 13, 2026
auto-merge was automatically disabled
March 13, 2026 20:58
Head branch was pushed to by a user without write access
Manishearth
approved these changes
Mar 13, 2026
Member
Manishearth
left a comment
There was a problem hiding this comment.
Verified that LocationOutOfBoundsError is decently written and ready to be public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to get observational islamic date for locations other than
MECCAandCAIROExample:
Changelog
calendrical_calculations: Changed
Location::try_newfrompub(crate)topubLocation::try_new()LocationOutOfBoundsError