Skip to content

Made Location::try_new public #7775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Manishearth merged 5 commits into from
Mar 13, 2026
+6 −5
Merged

Made Location::try_new public #7775

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2bcb32
feat: made Location::try_new public
Ghamza-Jd Mar 12, 2026
38980d2
docs: added min and max utc offset bound docs
Ghamza-Jd Mar 13, 2026
0e9c445
docs: removed MIN_UTC_OFFSET and MAX_UTC_OFFSET doc link references a…
Ghamza-Jd Mar 13, 2026
d10a04a
feat: made calendrical_calculations error public
Ghamza-Jd Mar 13, 2026
c94dc3b
Merge branch 'main' into patch-1
Ghamza-Jd Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions utils/calendrical_calculations/src/astronomy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ pub struct Location {
pub(crate) longitude: f64,
/// elevation in meters
pub(crate) elevation: f64,
/// UTC timezone offset in fractional days (1 hr = 1.0 / 24.0 day)
/// UTC timezone offset in fractional days (1 hr = 1.0 / 24.0 day),
/// within the range [`MIN_UTC_OFFSET`] (-12.0 / 24.0) to [`MAX_UTC_OFFSET`] (14.0 / 24.0)
pub(crate) utc_offset: f64,
}

Expand Down Expand Up @@ -77,10 +78,10 @@ pub const WINTER: f64 = 270.0;
pub const NEW_MOON_ZERO: Moment = Moment::new(11.458922815770109);

impl Location {
/// Create a location; latitude is from -90 to 90, and longitude is from -180 to 180;
/// Create a location; latitude is from -90 to 90, longitude is from -180 to 180,
/// and `utc_offset` is from [`MIN_UTC_OFFSET`] (-12.0 / 24.0) to [`MAX_UTC_OFFSET`] (14.0 / 24.0);
/// attempting to create a location outside of these bounds will result in a [`LocationOutOfBoundsError`].
#[allow(dead_code)] // TODO: Remove dead_code tag after use
pub(crate) fn try_new(
pub fn try_new(
latitude: f64,
longitude: f64,
elevation: f64,
Expand Down
Loading