fix: Avoid overwriting fstype with empty value#2675
Closed
jedevc wants to merge 2 commits intounikraft:stagingfrom
Closed
fix: Avoid overwriting fstype with empty value#2675jedevc wants to merge 2 commits intounikraft:stagingfrom
jedevc wants to merge 2 commits intounikraft:stagingfrom
Conversation
This value will be set to the empty string from the CLI if it's not explicitly set with `--rootfs-type`. This essentially results in overwriting the pre-populated default cpio type with an empty fs type. This then just silently skips the build in older versions of kraft, or causes a weirdly strange internal error on staging. Signed-off-by: Justin Chadwell <justin@unikraft.com>
Debugging without these is an absolute PITA. Signed-off-by: Justin Chadwell <justin@unikraft.com>
craciunoiuc
approved these changes
Mar 3, 2026
Member
craciunoiuc
left a comment
craciunoiuc
left a comment
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
craciunoiuc
requested changes
Mar 3, 2026
Member
craciunoiuc
left a comment
craciunoiuc
left a comment
There was a problem hiding this comment.
removing my review cause I want to see how this works with my PR 👀
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
Description of changes
This value will be set to the empty string from the CLI if it's not explicitly set with
--rootfs-type. This essentially results in overwriting the pre-populated default cpio type with an empty fs type.This then just silently skips the build in older versions of kraft, or causes a weirdly strange internal error on staging.