Implement Challenges::Base#[] #139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acme::Client::Resources::Challenges.new may return a Hash instead of Challenges::* when it encountered unsupported challenge type. When an user is iterating authz#challenges, they have to check a class of an element in prior to use. Checking challenge#challenge_type is sometime useful than checking challenge#class when an user has a support of additional challenge_type which are uncovered in this gem.
unixcharles
reviewed
May 18, 2018
| def [](key) | ||
| to_h[key] | ||
| end | ||
|
|
There was a problem hiding this comment.
I'm not sure why not simply calling #to_h within your app for that use case?
Also, would you prefer to keep them as a challenge object? I could implement an UnknownChallenge and this way you could call status, request_validation, etc, directly on it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acme::Client::Resources::Challenges.newmay return a Hash instead ofChallenges::*when it encountered unsupported challenge type.When an user is iterating
authz#challenges, they have to check a class of an element in prior to use.Checking
challenge#challenge_typeis sometime useful than checkingchallenge#classwhen an user has a support of additional challenge_type which are uncovered in this gem.(And I failed here... https://github.com/sorah/acmesmith/blob/5845dbadd7e9a1ad2ebd4731304d8f59b111ae68/lib/acmesmith/client.rb#L205 )