Skip to content

Implement Challenges::Base#[] #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Implement Challenges::Base#[] #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/acme/client/resources/challenges/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ def initialize(client, **arguments)
assign_attributes(arguments)
end

def [](key)
to_h[key]
end

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why not simply calling #to_h within your app for that use case?

Also, would you prefer to keep them as a challenge object? I could implement an UnknownChallenge and this way you could call status, request_validation, etc, directly on it?

def challenge_type
self.class::CHALLENGE_TYPE
end
Expand Down