Skip to content

Correctly specify non_email_login for standardized launchers#253

Merged
evan-goode merged 2 commits intounmojang:masterfrom
AzaContrib:master
Feb 28, 2026
Merged

Correctly specify non_email_login for standardized launchers#253
evan-goode merged 2 commits intounmojang:masterfrom
AzaContrib:master

Conversation

@hykilpikonna
Copy link
Contributor

This authlib standard requires all servers to have feature.non_email_login = true if it doesn't require the log-in username to be an email.

Drasl doesn't require the username to be an email, but did not add this field, which defaulted to false.

HMCL (launcher) queries Drasl, and see this missing field, and think that this server require usernames to be email, so it forces users to input an email.

Finally, users can't log in via HMCL because their username is not an email.

References:

image

Copilot AI review requested due to automatic review settings February 28, 2026 08:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Drasl’s authlib-injector metadata to comply with the authlib-injector “standardized launcher” requirement by explicitly advertising that the server supports non-email usernames, preventing launchers (e.g., HMCL) from forcing email-only login.

Changes:

  • Add feature.non_email_login to the authlib-injector meta JSON schema.
  • Set feature.non_email_login = true in the /authlib-injector response.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've been meaning to do that.

@evan-goode evan-goode merged commit 13ea4b7 into unmojang:master Feb 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants