Skip to content

Correctly specify non_email_login for standardized launchers #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evan-goode merged 2 commits into from
Feb 28, 2026
Merged

Correctly specify non_email_login for standardized launchers #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e7adc8
[O] Allow non-email login
hykilpikonna Feb 28, 2026
10fa902
[+] Tests
hykilpikonna Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions authlib_injector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ type authlibInjectorMeta struct {
Links authlibInjectorLinks `json:"links"`
ServerName string `json:"serverName"`
FeatureEnableProfileKey bool `json:"feature.enable_profile_key"`
FeatureNonEmailLogin bool `json:"feature.non_email_login"`
}

type authlibInjectorResponse struct {
Expand Down Expand Up @@ -76,6 +77,7 @@ func AuthlibInjectorRoot(app *App) func(c echo.Context) error {
},
ServerName: app.Config.InstanceName,
FeatureEnableProfileKey: true,
FeatureNonEmailLogin: true,
},
SignaturePublickey: signaturePublicKey,
SignaturePublickeys: signaturePublicKeys,
Expand Down
2 changes: 2 additions & 0 deletions authlib_injector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ func (ts *TestSuite) testAuthlibInjectorRoot(t *testing.T) {
assert.Equal(t, ts.App.FrontEndURL, response.Meta.Links.Homepage)
assert.Equal(t, Unwrap(url.JoinPath(ts.App.FrontEndURL, "web/registration")), response.Meta.Links.Register)
assert.Equal(t, []string{ts.App.Config.Domain}, response.SkinDomains)
assert.True(t, response.Meta.FeatureNonEmailLogin)
}

func (ts *TestSuite) testAuthlibInjectorRootFallback(t *testing.T) {
Expand All @@ -71,6 +72,7 @@ func (ts *TestSuite) testAuthlibInjectorRootFallback(t *testing.T) {
assert.Nil(t, json.NewDecoder(rec.Body).Decode(&response))

assert.Equal(t, []string{ts.App.Config.Domain, FALLBACK_SKIN_DOMAIN_A, FALLBACK_SKIN_DOMAIN_B}, response.SkinDomains)
assert.True(t, response.Meta.FeatureNonEmailLogin)
}

func (ts *TestSuite) testAuthlibInjectorTextureUploadDelete(t *testing.T) {
Expand Down