Merged
Conversation
47718af to
0967e29
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refines the file uploader components by adding explicit type annotations and updates the Node.js version in the CI workflow.
- Explicitly typed FileUploader components for Regular, Minimal, and Inline variants
- Updated Node.js version from 16 to 18 in the GitHub Actions workflow
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-uploader/src/Uploader/Regular/NextFileUploaderRegular.ts | Added explicit type annotation for the Regular uploader component. |
| packages/react-uploader/src/Uploader/Minimal/NextFileUploaderMinimal.ts | Added explicit type annotation for the Minimal uploader component; note slight import order variation. |
| packages/react-uploader/src/Uploader/Inline/NextFileUploaderInline.ts | Added explicit type annotation for the Inline uploader component. |
| .github/workflows/checks.yml | Updated Node.js version from 16 to 18 for CI consistency. |
Files not reviewed (2)
- packages/react-adapter/package.json: Language not supported
- packages/react-uploader/package.json: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/checks.yml:16
- Confirm that the CI pipeline and associated build scripts are fully compatible with Node 18 to prevent potential build issues.
node-version: "18"
Comment on lines
+1
to
2
| import { ComponentType } from "react"; | ||
| import dynamic from "next/dynamic"; |
There was a problem hiding this comment.
[nitpick] The import order in this file differs from the Regular and Inline uploader files. Consider aligning the import ordering for consistency across similar components.
Suggested change
| import { ComponentType } from "react"; | |
| import dynamic from "next/dynamic"; | |
| import dynamic from "next/dynamic"; | |
| import { ComponentType } from "react"; |
nd0ut
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist