Skip to content

Chore/update deps types#67

Merged
egordidenko merged 3 commits intomainfrom
chore/update-deps-types
May 7, 2025
Merged

Chore/update deps types#67
egordidenko merged 3 commits intomainfrom
chore/update-deps-types

Conversation

@egordidenko
Copy link
Contributor

Description

Checklist

@egordidenko egordidenko requested a review from Copilot May 7, 2025 10:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@egordidenko egordidenko force-pushed the chore/update-deps-types branch from 47718af to 0967e29 Compare May 7, 2025 10:31
@egordidenko egordidenko requested a review from Copilot May 7, 2025 10:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the file uploader components by adding explicit type annotations and updates the Node.js version in the CI workflow.

  • Explicitly typed FileUploader components for Regular, Minimal, and Inline variants
  • Updated Node.js version from 16 to 18 in the GitHub Actions workflow

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

File Description
packages/react-uploader/src/Uploader/Regular/NextFileUploaderRegular.ts Added explicit type annotation for the Regular uploader component.
packages/react-uploader/src/Uploader/Minimal/NextFileUploaderMinimal.ts Added explicit type annotation for the Minimal uploader component; note slight import order variation.
packages/react-uploader/src/Uploader/Inline/NextFileUploaderInline.ts Added explicit type annotation for the Inline uploader component.
.github/workflows/checks.yml Updated Node.js version from 16 to 18 for CI consistency.
Files not reviewed (2)
  • packages/react-adapter/package.json: Language not supported
  • packages/react-uploader/package.json: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/checks.yml:16

  • Confirm that the CI pipeline and associated build scripts are fully compatible with Node 18 to prevent potential build issues.
node-version: "18"

Comment on lines +1 to 2
import { ComponentType } from "react";
import dynamic from "next/dynamic";
Copy link

Copilot AI May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The import order in this file differs from the Regular and Inline uploader files. Consider aligning the import ordering for consistency across similar components.

Suggested change
import { ComponentType } from "react";
import dynamic from "next/dynamic";
import dynamic from "next/dynamic";
import { ComponentType } from "react";

Copilot uses AI. Check for mistakes.
@egordidenko egordidenko merged commit f15435e into main May 7, 2025
3 checks passed
@egordidenko egordidenko deleted the chore/update-deps-types branch May 7, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants