Skip to content

Chore/update deps types #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egordidenko merged 3 commits into from
May 7, 2025
Merged

Chore/update deps types #67

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
724cdf3
chore(react-uploader): updated types for nextjs
May 7, 2025
53306ff
chore(react-adapter): updated deps @types/react
May 7, 2025
0967e29
chore(ci): increased node-version to 18
May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/react-adapter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"test": "vitest"
},
"peerDependencies": {
"@types/react": "17 || 18"
"@types/react": ">= 17.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
3 changes: 1 addition & 2 deletions packages/react-uploader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
},
"./next": {
"import": "./dist/nextjs.js",
"require": "./dist/nextjs.cjs",
"types": "./dist/nextjs.d.ts"
"require": "./dist/nextjs.cjs"
},
"./core.css": "./dist/react-uploader.css"
},
Expand Down
6 changes: 4 additions & 2 deletions packages/react-uploader/src/Uploader/Inline/NextFileUploaderInline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import dynamic from "next/dynamic";
import { TProps } from "../types";
import { ComponentType } from "react";

export const FileUploaderInline = dynamic(
export const FileUploaderInline: ComponentType<TProps<"Inline">> = dynamic(
() => import("./FileUploaderInline").then((mod) => mod.FileUploaderInline),
{ ssr: false },
{ ssr: false }
);
6 changes: 4 additions & 2 deletions packages/react-uploader/src/Uploader/Minimal/NextFileUploaderMinimal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { ComponentType } from "react";
import dynamic from "next/dynamic";
Comment on lines +1 to 2
Copy link

Copilot AI May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The import order in this file differs from the Regular and Inline uploader files. Consider aligning the import ordering for consistency across similar components.

Suggested change
import { ComponentType } from "react";
import dynamic from "next/dynamic";
import dynamic from "next/dynamic";
import { ComponentType } from "react";

Copilot uses AI. Check for mistakes.
import { TProps } from "../types";

export const FileUploaderMinimal = dynamic(
export const FileUploaderMinimal: ComponentType<TProps<"Minimal">> = dynamic(
() => import("./FileUploaderMinimal").then((mod) => mod.FileUploaderMinimal),
{ ssr: false },
{ ssr: false }
);
6 changes: 4 additions & 2 deletions packages/react-uploader/src/Uploader/Regular/NextFileUploaderRegular.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import dynamic from "next/dynamic";
import { TProps } from "../types";
import { ComponentType } from "react";

export const FileUploaderRegular = dynamic(
export const FileUploaderRegular: ComponentType<TProps<"Regular">> = dynamic(
() => import("./FileUploaderRegular").then((mod) => mod.FileUploaderRegular),
{ ssr: false },
{ ssr: false }
);
Loading