feat cmake: add CPM to several depenencies#1004
Closed
Conversation
Anton3
reviewed
Aug 26, 2025
Anton3
requested changes
Aug 28, 2025
This reverts commit 48ddd77.
Anton3
requested changes
Sep 1, 2025
| add_library(libev::libev ALIAS libev) | ||
| elseif(libev_ADDED) | ||
| # nghttp2 doesn't use find_package(), but calls find_path() and find_library() | ||
| # so we have to provide libev.a at the _configure_ time, not at build time, =( |
Member
There was a problem hiding this comment.
Is it also necessary to build a fresh copy of libev on each reconfigure?
Member
|
Add newly spawned cmake variables to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #1003