Clearing diagnostics of transient files after a close event by mimicking a delete #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavyLandman
approved these changes
Nov 26, 2025
toinehartman
approved these changes
Nov 26, 2025
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our TextDocumentService implementations now explicitly check, after receiving and handling a
DidCloseTextDocumentevent, whether the closed file still exists. For transient files, such as unsaved untitled files, this will not be the case. In such cases, we now mimic a file deletion event in order to clear out any remaining diagnostics coupled to the closed file. This solves an issue where non-clearable (or, at least, not trivially clearable) diagnostics were kept around in the IDE.This is a partial fix for @urbanfly's test issues #894.