Fix incorrect allocation of cd_values array in get_dataset_filters()#117
Merged
bmaranville merged 1 commit intomainfrom Jan 6, 2026
Merged
Fix incorrect allocation of cd_values array in get_dataset_filters()#117bmaranville merged 1 commit intomainfrom
bmaranville merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For filters that use more than 16 elements in
cd_values, the current allocation call only allocatesnelementsbytes, but cd_values is array of unsigned int - need to allocatenelements * sizeof(unsigned int)Somehow this didn't throw an error before in tests (malloc sometimes allocates more than requested?) but with emcc version 4.0.22 it throws an error when running the
filters_test.