Skip to content

Fix incorrect allocation of cd_values array in get_dataset_filters() #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmaranville merged 1 commit into from
Jan 6, 2026
Merged

Fix incorrect allocation of cd_values array in get_dataset_filters() #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/hdf5_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,13 @@ val get_dataset_filters(hid_t loc_id, const std::string& dataset_name_string)
H5Z_filter_t filter_id = H5Pget_filter2(plist_id, i, &flags, &nelements, cd_values, 256, name, NULL);
val cd_values_out = val::array();
if (nelements > 16) {
unsigned int * full_cd_values = (unsigned int *)malloc(nelements);
unsigned int * full_cd_values = (unsigned int *)malloc(nelements * sizeof(unsigned int));
if (full_cd_values == NULL) {
H5Dclose(ds_id);
H5Pclose(plist_id);
throw_error("error - malloc failed for filter cd_values!");
return val::null();
}
H5Pget_filter2(plist_id, i, &flags, &nelements, full_cd_values, 256, name, NULL);
for (size_t i = 0; i < nelements; i++) {
cd_values_out.set(i, full_cd_values[i]);
Expand Down
Loading