-
Notifications
You must be signed in to change notification settings - Fork 107
chore(pm): update e2e #2475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
chore(pm): update e2e #2475
Conversation
Summary of ChangesHello @elrrrrrrr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates an existing end-to-end test script to introduce a more rigorous evaluation of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the end-to-end test script to add performance testing for utoo install with various --manifests-concurrency-limit values for the ant-design project. This change aligns its testing with the existing setup for ant-design-x. The implementation is correct, but it introduces a large block of duplicated code. My feedback focuses on refactoring this repeated logic into a reusable shell function to improve the script's maintainability.
| # Test different manifests-concurrency-limit values | ||
| echo -e "${YELLOW}Testing different manifests-concurrency-limit values...${NC}" | ||
| for limit in 10 20 40 60 70 80 90 100 120 200; do | ||
| echo -e "${YELLOW}--- Testing manifests-concurrency-limit=$limit ---${NC}" | ||
| rm -rf node_modules package-lock.json | ||
| rm -rf ~/.cache/nm | ||
| time utoo install --ignore-scripts --manifests-concurrency-limit $limit || { echo -e "${RED}FAIL: utoo install failed with limit=$limit${NC}"; exit 1; } | ||
| echo -e "${GREEN}PASS: limit=$limit completed${NC}" | ||
| echo "" | ||
| done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block of code is almost identical to the one used for ant-design-x (lines 27-36). To avoid code duplication and improve maintainability, this logic should be extracted into a reusable shell function.
You can define a function at the top of the script (e.g., after the color definitions) like this:
function test_concurrency_limits() {
local project_name="$1"
echo -e "${YELLOW}Testing different manifests-concurrency-limit values for ${project_name}...${NC}"
for limit in 10 20 40 60 70 80 90 100 120 200; do
echo -e "${YELLOW}--- Testing manifests-concurrency-limit=$limit ---${NC}"
rm -rf node_modules package-lock.json
rm -rf ~/.cache/nm
time utoo install --ignore-scripts --manifests-concurrency-limit $limit || { echo -e "${RED}FAIL: utoo install failed for ${project_name} with limit=$limit${NC}"; exit 1; }
echo -e "${GREEN}PASS: limit=$limit completed for ${project_name}${NC}"
echo ""
done
}Then, you can replace this entire block with a single call to this function. The same function can then be used to refactor the test for ant-design-x.
| # Test different manifests-concurrency-limit values | |
| echo -e "${YELLOW}Testing different manifests-concurrency-limit values...${NC}" | |
| for limit in 10 20 40 60 70 80 90 100 120 200; do | |
| echo -e "${YELLOW}--- Testing manifests-concurrency-limit=$limit ---${NC}" | |
| rm -rf node_modules package-lock.json | |
| rm -rf ~/.cache/nm | |
| time utoo install --ignore-scripts --manifests-concurrency-limit $limit || { echo -e "${RED}FAIL: utoo install failed with limit=$limit${NC}"; exit 1; } | |
| echo -e "${GREEN}PASS: limit=$limit completed${NC}" | |
| echo "" | |
| done | |
| test_concurrency_limits "ant-design" |
f77808c to
567e5ae
Compare
No description provided.