Skip to content

chore(pm): update e2e #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
elrrrrrrr wants to merge 3 commits into
base: next
Choose a base branch
from
Draft

chore(pm): update e2e #2475

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aceecc3
chore: e2e
elrrrrrrr Jan 1, 2026
750aba7
Merge branch 'next' into udpate-e2e
elrrrrrrr Jan 6, 2026
5aa7e6d
Merge branch 'next' into udpate-e2e
xusd320 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions e2e/utoo-pm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,26 @@ utoo rebuild || { echo -e "${RED}FAIL: utoo rebuild failed for ant-design-x (nex
echo -e "${GREEN}PASS: ant-design-x (next) cloned and installed${NC}"
cd ../../

# Case 2: Clone and install ant-design
# Case 2: Clone and install ant-design - test manifests-concurrency-limit
echo -e "${YELLOW}Case 2: Clone and install ant-design${NC}"
cd ant-design
if [ ! -d "ant-design" ]; then
git clone --depth=1 --single-branch https://github.com/ant-design/ant-design.git
fi
cd ant-design
rm -rf ~/.cache/nm
echo "Installing dependencies for ant-design..."
utoo install --ignore-scripts || { echo -e "${RED}FAIL: utoo install failed for ant-design${NC}"; exit 1; }

# Test different manifests-concurrency-limit values
echo -e "${YELLOW}Testing different manifests-concurrency-limit values...${NC}"
for limit in 10 20 40 60 70 80 90 100 120 200; do
echo -e "${YELLOW}--- Testing manifests-concurrency-limit=$limit ---${NC}"
rm -rf node_modules package-lock.json
rm -rf ~/.cache/nm
time utoo install --ignore-scripts --manifests-concurrency-limit $limit || { echo -e "${RED}FAIL: utoo install failed with limit=$limit${NC}"; exit 1; }
echo -e "${GREEN}PASS: limit=$limit completed${NC}"
echo ""
done
Comment on lines +50 to +59
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This block of code is almost identical to the one used for ant-design-x (lines 27-36). To avoid code duplication and improve maintainability, this logic should be extracted into a reusable shell function.

You can define a function at the top of the script (e.g., after the color definitions) like this:

function test_concurrency_limits() {
  local project_name="$1"
  echo -e "${YELLOW}Testing different manifests-concurrency-limit values for ${project_name}...${NC}"
  for limit in 10 20 40 60 70 80 90 100 120 200; do
    echo -e "${YELLOW}--- Testing manifests-concurrency-limit=$limit ---${NC}"
    rm -rf node_modules package-lock.json
    rm -rf ~/.cache/nm
    time utoo install --ignore-scripts --manifests-concurrency-limit $limit || { echo -e "${RED}FAIL: utoo install failed for ${project_name} with limit=$limit${NC}"; exit 1; }
    echo -e "${GREEN}PASS: limit=$limit completed for ${project_name}${NC}"
    echo ""
  done
}

Then, you can replace this entire block with a single call to this function. The same function can then be used to refactor the test for ant-design-x.

Suggested change
# Test different manifests-concurrency-limit values
echo -e "${YELLOW}Testing different manifests-concurrency-limit values...${NC}"
for limit in 10 20 40 60 70 80 90 100 120 200; do
echo -e "${YELLOW}--- Testing manifests-concurrency-limit=$limit ---${NC}"
rm -rf node_modules package-lock.json
rm -rf ~/.cache/nm
time utoo install --ignore-scripts --manifests-concurrency-limit $limit || { echo -e "${RED}FAIL: utoo install failed with limit=$limit${NC}"; exit 1; }
echo -e "${GREEN}PASS: limit=$limit completed${NC}"
echo ""
done
test_concurrency_limits "ant-design"


utoo rebuild || { echo -e "${RED}FAIL: utoo rebuild failed for ant-design${NC}"; exit 1; }
echo -e "${GREEN}PASS: ant-design cloned and installed${NC}"
cd ../../

Expand Down