Skip to content

shred: ensure deterministic pass sequence compatibility with reference implementation #9317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 3 commits into from
Dec 22, 2025
Merged

shred: ensure deterministic pass sequence compatibility with reference implementation #9317

cakebaker merged 3 commits into from
Dec 22, 2025

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Nov 17, 2025

should fix tests/shred/shred-passes.sh

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/shred/shred-passes is no longer failing!

@oech3

This comment was marked as resolved.

Sign in to view
@sylvestre sylvestre force-pushed the shred-passes branch 2 times, most recently from 7d9a9ce to 4d5eed9 Compare November 18, 2025 06:41
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/shred/shred-passes is no longer failing!

cakebaker
cakebaker reviewed Nov 18, 2025
View reviewed changes
@oech3
Copy link
Contributor

oech3 commented Dec 2, 2025

Needs cleanup https://github.com/uutils/coreutils/blob/main/util/why-error.md

@ChrisDryden ChrisDryden mentioned this pull request Dec 19, 2025
Open
@github-actions
Copy link

github-actions bot commented Dec 20, 2025

GNU testsuite comparison:

GNU test failed: tests/runcon/runcon-compute. tests/runcon/runcon-compute is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/runcon/runcon-no-reorder is no longer failing!
Congrats! The gnu test tests/shred/shred-passes is no longer failing!

@sylvestre sylvestre requested a review from cakebaker December 20, 2025 10:42
@cakebaker cakebaker merged commit 87ba3af into uutils:main Dec 22, 2025
127 of 128 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Dec 22, 2025

Congrats! The gnu test tests/shred/shred-passes is no longer failing!

Kudos!

@cakebaker cakebaker mentioned this pull request Dec 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sylvestre @oech3 @cakebaker