Skip to content

shred: ensure deterministic pass sequence compatibility with reference implementation #9317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cakebaker merged 3 commits into from
Dec 22, 2025
Merged

shred: ensure deterministic pass sequence compatibility with reference implementation #9317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd21d7f
shred: ensure deterministic pass sequence compatibility with referenc…
sylvestre Nov 17, 2025
ceb2551
shred: remove the extension section
sylvestre Nov 18, 2025
2e3a1ad
shred: use RefCell to eliminate mut from random source handling
sylvestre Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/src/extensions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,6 @@ Similar to the proc-ps implementation and unlike GNU/Coreutils, `uptime` provide

Just like on macOS, `base32/base64/basenc` provides `-D` to decode data.

## `shred`

The number of random passes is deterministic in both GNU and uutils. However, uutils `shred` computes the number of random passes in a simplified way, specifically `max(3, x / 10)`, which is very close but not identical to the number of random passes that GNU would do. This also satisfies an expectation that reasonable users might have, namely that the number of random passes increases monotonically with the number of passes overall; GNU `shred` violates this assumption.

## `unexpand`

GNU `unexpand` provides `--first-only` to convert only leading sequences of blanks. We support a
Expand Down
7 changes: 7 additions & 0 deletions src/uu/shred/locales/en-US.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,10 @@ shred-couldnt-rename = {$file}: Couldn't rename to {$new_name}: {$error}
shred-failed-to-open-for-writing = {$file}: failed to open for writing
shred-file-write-pass-failed = {$file}: File write pass failed
shred-failed-to-remove-file = {$file}: failed to remove file

# File I/O error messages
shred-failed-to-clone-file-handle = failed to clone file handle
shred-failed-to-seek-file = failed to seek in file
shred-failed-to-read-seed-bytes = failed to read seed bytes from file
shred-failed-to-get-metadata = failed to get file metadata
shred-failed-to-set-permissions = failed to set file permissions
7 changes: 7 additions & 0 deletions src/uu/shred/locales/fr-FR.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,10 @@ shred-couldnt-rename = {$file} : Impossible de renommer en {$new_name} : {$error
shred-failed-to-open-for-writing = {$file} : impossible d'ouvrir pour l'écriture
shred-file-write-pass-failed = {$file} : Échec du passage d'écriture de fichier
shred-failed-to-remove-file = {$file} : impossible de supprimer le fichier

# Messages d'erreur E/S de fichier
shred-failed-to-clone-file-handle = échec du clonage du descripteur de fichier
shred-failed-to-seek-file = échec de la recherche dans le fichier
shred-failed-to-read-seed-bytes = échec de la lecture des octets de graine du fichier
shred-failed-to-get-metadata = échec de l'obtention des métadonnées du fichier
shred-failed-to-set-permissions = échec de la définition des permissions du fichier
Loading
Loading