stty: baud parsing integration tests and validation #9454
Merged
+89
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDryden
force-pushed
the
stty_baud_parsing
branch
from
59c3d7f to
4109484
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
ChrisDryden
changed the title
Contributor
|
Thanks! |
This was referenced Nov 24, 2025
martinkunkel2
pushed a commit
to martinkunkel2/coreutils
that referenced
this pull request
Nov 30, 2025
* Adding comprehensive gnu suite baud parsing rules * Adding missing spellcheck words * Fixed clippy errors and simplified rounding logic
martinkunkel2
pushed a commit
to martinkunkel2/coreutils
that referenced
this pull request
Nov 30, 2025
* Adding comprehensive gnu suite baud parsing rules * Adding missing spellcheck words * Fixed clippy errors and simplified rounding logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the PR for enabling the stty tests in Github actions, have set up the integration testing for stty and have a working PR that when combined passes all of the GNU tests #9427, I am splitting up all of the different components of that PR and adding integration tests for each of the changes.
The change that would allow these tests to run the stty GNU tests is this one: #9336
This change specifically focuses on what is a valid baud value and the very specific parsing rules that are added in stty.
Stty has very specific rounding rules for backwards compatibility to do bankers rounding except for the value of .5 which rounds to the nearest even integer. It also has very specific rules related to things such as +, -, spaces. All of the values used in the GNU integration tests are added now to the test_stty.rs file