gnu-tests: enable tac-continue and adapt expected result#9590
Closed
martinkunkel2 wants to merge 2 commits intouutils:mainfrom
Closed
gnu-tests: enable tac-continue and adapt expected result#9590martinkunkel2 wants to merge 2 commits intouutils:mainfrom
martinkunkel2 wants to merge 2 commits intouutils:mainfrom
Conversation
Contributor
Author
martinkunkel2
force-pushed
the
gnu-tac-continue-test
branch
from
a556cd4 to
17dcd1e
Compare
tac/tac-continue test needs a temporary directory which is on a partition in which you can still create files, but where no free space is left.
Add a patch that changes the expected behavior in tac-continue test to match uutils implementation of tac. The test expects that a temporary file has to be opened and written to. This is not the case for uutils implementation.
martinkunkel2
force-pushed
the
gnu-tac-continue-test
branch
from
17dcd1e to
65f5655
Compare
martinkunkel2
changed the title
martinkunkel2
changed the title
|
GNU testsuite comparison: |
oech3
reviewed
Dec 7, 2025
| run: | | ||
| # for tac/tac-continue test | ||
| export FULL_PARTITION_TMPDIR=/mnt/full_partition | ||
| sudo mount --mkdir=0777 --types tmpfs --options size=1M tmpfs $FULL_PARTITION_TMPDIR |
Contributor
There was a problem hiding this comment.
@pixelb Can GNU include operation equivalent with this to tac-continue itself?
Contributor
There was a problem hiding this comment.
@pixelb Thankyou for using yes at #9594 (comment) . It should work with uutils.
@martinkunkel2 Thankyou for opening this. But backporting new tests is difficult some reason (see #9530 (comment)). So we will close this now. Tell me if you find a reasonable way for backporting.
Contributor
Author
There was a problem hiding this comment.
yes, let's close it here.
oech3
reviewed
Dec 7, 2025
| + | ||
| +# uutils does not create this temporary file in $TMPDIR, so the expected result is different | ||
| +# there is just no difference from normal operation | ||
| +# that means tac returns with success and the expected output the reverse of inputs |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
gitmirroring-auto-sync-bot bot
pushed a commit
to GitMirroring/coreutils
that referenced
this pull request
Dec 7, 2025
* tests/tac/tac-continue.sh: This test was very awkard to setup, and thus always skipped. Instead move to a root only test that creates an almost full partition itself. * tests/local.mk: Move test to root only. Suggested at uutils/coreutils#9590
Contributor
Author
|
@pixelb Thank you for refactoring the test in GNU coreutils, including the setup of the tmpfs. Let's close this and wait for integration of next release. |
thalinda-oss
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in CI enable the tac-continue test, so that it is not skipped anymore.
This will result in failure instead, as the behavior of uutils is different.
With the patch we could change the expected behavior.