Skip to content

gnu-tests: enable tac-continue and adapt expected result #9590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinkunkel2 wants to merge 2 commits into from
Closed

gnu-tests: enable tac-continue and adapt expected result #9590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3586f4d
gnu-tests: create full partition for tac-continue
martinkunkel2 Dec 7, 2025
65f5655
gnu-tests: adapt expected behavior of tac-continue
martinkunkel2 Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/GnuTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: GnuTests

# spell-checker:ignore (abbrev/names) CodeCov gnulib GnuTests Swatinem
# spell-checker:ignore (abbrev/names) CodeCov gnulib GnuTests Swatinem tmpfs
# spell-checker:ignore (jargon) submodules devel
# spell-checker:ignore (libs/utils) autopoint chksum getenforce gperf lcov libexpect limactl pyinotify setenforce shopt texinfo valgrind libattr libcap taiki-e
# spell-checker:ignore (options) Ccodegen Coverflow Cpanic Zpanic
Expand Down Expand Up @@ -115,6 +115,16 @@ jobs:
cd 'uutils'
env PROFILE=release-small bash util/build-gnu.sh

### Test environment setup
- name: Setup specific GNU tests environment
shell: bash
run: |
# for tac/tac-continue test
export FULL_PARTITION_TMPDIR=/mnt/full_partition
sudo mount --mkdir=0777 --types tmpfs --options size=1M tmpfs $FULL_PARTITION_TMPDIR
Copy link
Contributor

@oech3 oech3 Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pixelb Can GNU include operation equivalent with this to tac-continue itself?

Copy link
Contributor

@oech3 oech3 Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pixelb Thankyou for using yes at #9594 (comment) . It should work with uutils.

@martinkunkel2 Thankyou for opening this. But backporting new tests is difficult some reason (see #9530 (comment)). So we will close this now. Tell me if you find a reasonable way for backporting.

Copy link
Contributor Author

@martinkunkel2 martinkunkel2 Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, let's close it here.

dd if=/dev/zero of=$FULL_PARTITION_TMPDIR/data bs=1M count=1
echo "FULL_PARTITION_TMPDIR=$FULL_PARTITION_TMPDIR" >> $GITHUB_ENV

### Run tests as user
- name: Run GNU tests
shell: bash
Expand Down
1 change: 1 addition & 0 deletions util/gnu-patches/series
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ tests_sort_merge.pl.patch
tests_tsort.patch
tests_du_move_dir_while_traversing.patch
test_mkdir_restorecon.patch
tests_tac_continue.patch
error_msg_uniq.diff
24 changes: 24 additions & 0 deletions util/gnu-patches/tests_tac_continue.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
Index: gnu/tests/tac/tac-continue.sh
===================================================================
--- gnu.orig/tests/tac/tac-continue.sh
+++ gnu/tests/tac/tac-continue.sh
@@ -59,11 +59,17 @@ seq 5 > in

# Give tac a fifo command line argument.
# This makes it try to create a temporary file in $TMPDIR.
+
+# uutils does not create this temporary file in $TMPDIR, so the expected result is different
+# there is just no difference from normal operation
+# that means tac returns with success and the expected output the reverse of inputs

This comment was marked as resolved.

Sign in to view

+
mkfifo_or_skip_ fifo
seq 1000 > fifo & pid=$!
-TMPDIR=$FULL_PARTITION_TMPDIR tac fifo in >out 2>err && fail=1
+TMPDIR=$FULL_PARTITION_TMPDIR tac fifo in >out 2>err || fail=1

-cat <<\EOF > exp || framework_failure_
+seq 1000 -1 1 > exp || framework_failure_
+cat <<\EOF >> exp || framework_failure_
5
4
3
3 changes: 0 additions & 3 deletions util/why-skip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@
= timeout returned 142. SIGALRM not handled? =
* tests/misc/timeout-group.sh

= FULL_PARTITION_TMPDIR not defined =
* tests/misc/tac-continue.sh

= can't get window size =
* tests/misc/stty-row-col.sh

Expand Down
Loading